Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Applicable Zod validations with those from Regtech-Regex #1096

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Replace Applicable Zod validations with those from Regtech-Regex #1096

merged 8 commits into from
Dec 20, 2024

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Dec 12, 2024 •
edited
Loading

Added dependency to regtech-regex and updated the zod stuff to use the regexs held within.

Changes

  • Updated dependencies
  • Added dependency to regtech-regex
  • Updated zod validations with the regexes from regtech-regex

How to test this PR

  1. Validate that the pipeline is green
  2. Pull the branch
  3. Run yarn install
  4. Launch the app
  5. Create a new filing and validate that you are able to reach the submission page

@tanner-ricks tanner-ricks changed the title Draft: Replace Applicable Zod validations with those from Regtech-Regex Replace Applicable Zod validations with those from Regtech-Regex Dec 20, 2024
@tanner-ricks tanner-ricks marked this pull request as ready for review December 20, 2024 19:23
billhimmelsbach
billhimmelsbach requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! One small thing to fix, but then this is ready to go.

src/types/formTypes.ts Show resolved Hide resolved
billhimmelsbach
billhimmelsbach approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works! Thanks.

@tanner-ricks tanner-ricks enabled auto-merge (squash) December 20, 2024 22:45
@tanner-ricks tanner-ricks merged commit 806d72d into main Dec 20, 2024
10 checks passed
@tanner-ricks tanner-ricks deleted the 1069-regtech-regex-in-zod branch December 20, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billhimmelsbach billhimmelsbach billhimmelsbach approved these changes

@meissadia meissadia Awaiting requested review from meissadia meissadia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanner-ricks @billhimmelsbach